rmuir commented on code in PR #15753:
URL: https://github.com/apache/lucene/pull/15753#discussion_r2842369799
##########
lucene/core/src/java/org/apache/lucene/util/automaton/Automata.java:
##########
@@ -557,6 +566,31 @@ public static Automaton makeString(String s) {
return a;
}
+ /**
+ * Returns a new (deterministic) automaton that accepts the single given
string and the
+ * case-insensitive equivalents.
+ */
Review Comment:
Do you know, are these always minimal DFA? I think they might be (not just
the particular one in the test), just still slow on coffee today.
If so, can we document it, to match the other `makeXXX*` functions javadocs?
I know the information is missing for some of the "trivial" ones, but when we
add case-insensitivity to the mix, we're no longer trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
