ayagmar commented on issue #14496: URL: https://github.com/apache/lucene/issues/14496#issuecomment-4119417015
Hello @stefanvodita I checked the recent dry-run behavior and the planner decisions look correct and solid! but I don’t think we should disable dry-run yet, though. The current workflow runs in the `pull_request` context, and for cross-repo PRs that gives a read-only `GITHUB_TOKEN`. In practice that likely means actual backport creation would fail when it tries to push the backport branch / open the PR, even though the planning step is correct. I think the next step should be to move this to a write-capable post-merge context (likely `pull_request_target` with `types: [closed]` and the existing merged check), while keeping it strictly in base-repo context and not checking out or executing PR head code. I opened a pr for that https://github.com/apache/lucene/pull/15865 for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
