rmuir commented on PR #15939: URL: https://github.com/apache/lucene/pull/15939#issuecomment-4202908300
Feel free to toss this PR if anyone wants to iterate elsewhere, I mainly wanted to: * prototype what it would look like to remove these parameters from queries/parsers api * see how the tests behaved when I took away the DFA and try to understand what else needs to be done If we could get this "implicit" determinization out of all places where it can go exponential, then it simplifies the problem: determinization only happens if the user themself does it. e.g. for RegexpQuery, if a user really really wants a DFA for some special purpose, they can still do it, but it is because they are calling themselves calling determinize(): ```java var automaton = regexp.toAutomation(); var dfa = Operations.determinize(automaton); new AutomatonQuery(dfa, ...) ``` This simplifies the problem because then we can think about how `determinize()` should look without concerning ourselves with how it will "cascade" across a ton of other APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
