rmuir commented on PR #15939: URL: https://github.com/apache/lucene/pull/15939#issuecomment-4216379942
> Does this PR means NFA will become default (unless the user's regexp happens to be translated to a DFA directly)? That's correct. We fixed a lot of inefficient problems with Regexp parser and some of the automaton helpers functions though, so they make less NFAs than before. Previously you'd get an NFA for silly reasons. If the user wants to FORCE a DFA, they should call `determinize()` themselves? I'm sure some use-cases might get slower, but other ones might get faster too. RegexpQuery is kinda like using a non-compiled "pattern", it is convenience for a one-off. If you have a single pattern that is going to be heavily reused, you can use AutomatonQuery. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
