rmuir commented on code in PR #15983:
URL: https://github.com/apache/lucene/pull/15983#discussion_r3149937885
##########
build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/ProfileResults.java:
##########
@@ -121,6 +127,24 @@ static boolean isGradlePollThread(RecordedThread thread) {
return (thread != null && thread.getJavaName().startsWith("/127.0.0.1"));
}
+ /**
+ * Pre-scan recording files to detect if any jdk.CPUTimeSample events are
present. When they are,
+ * we prefer them over legacy jdk.ExecutionSample/jdk.NativeMethodSample to
avoid double-counting.
+ */
+ static boolean detectCPUTimeSamples(List<String> files) throws IOException {
Review Comment:
Instead of this logic, should we just have profiling.linux.jfc that is
loaded for linux, and profiling.jfc used for others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
