rmuir commented on code in PR #15983:
URL: https://github.com/apache/lucene/pull/15983#discussion_r3150342939
##########
build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/ProfileResults.java:
##########
@@ -101,10 +101,17 @@ public static void main(String[] args) throws IOException
{
}
/** true if we care about this event */
- static boolean isInteresting(String mode, RecordedEvent event) {
+ static boolean isInteresting(String mode, RecordedEvent event, boolean
hasCPUTimeSamples) {
String name = event.getEventType().getName();
switch (mode) {
case "cpu":
+ if (hasCPUTimeSamples) {
Review Comment:
I don't think we need this boolean parameter nor the if block.
Just something like:
```java
return name.equals("jdk.CPUTimeSample") ||
name.equals("jdk.ExecutionSample") ||
name.equals("jdk.NativeMethodSample");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
