jainankitk commented on code in PR #16141:
URL: https://github.com/apache/lucene/pull/16141#discussion_r3314427877
##########
lucene/core/src/java/org/apache/lucene/search/Weight.java:
##########
@@ -228,9 +230,12 @@ public long cost() {
* @lucene.internal
*/
protected static class DefaultBulkScorer extends BulkScorer {
+ private static final int WINDOW_SIZE = 1 << 12;
Review Comment:
I am assuming this value of `WINDOW_SIZE` is coming from
`DenseConjunctionBulkScorer`. Should we use common value at both the places?
##########
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java:
##########
@@ -147,6 +147,10 @@ public float score() throws IOException {
return score;
}
+ boolean canBulkCollectDocIdStream() {
+ return scoreMode != ScoreMode.TOP_SCORES;
+ }
Review Comment:
Failing tests might need change in `AssertingScorer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
