romseygeek commented on code in PR #16141:
URL: https://github.com/apache/lucene/pull/16141#discussion_r3316482339
##########
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java:
##########
@@ -147,6 +147,10 @@ public float score() throws IOException {
return score;
}
+ boolean canBulkCollectDocIdStream() {
+ return scoreMode != ScoreMode.TOP_SCORES;
+ }
Review Comment:
Yeah I think we need to tighten the API around collectRange() and
collect(DocIdStream) - it doesn't make sense to get scores inside these methods
because the Scorer isn't going to be correctly positioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
