Pulkitg64 commented on code in PR #16383:
URL: https://github.com/apache/lucene/pull/16383#discussion_r3627149936
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene102/Lucene102BinaryFlatVectorsScorer.java:
##########
@@ -94,6 +94,13 @@ public RandomVectorScorer getRandomVectorScorer(
return nonQuantizedDelegate.getRandomVectorScorer(similarityFunction,
vectorValues, target);
}
+ @Override
+ public RandomVectorScorer getRandomVectorScorer(
Review Comment:
Actually here I followed the same pattern as Byte vector encoding, I think
byte vector encoding was implemented in the same way where we added
`UnsupportedOperationException` explicitly in every backward codec files.
Moreover since these functions are abstract (`getRandomVectorScorer`,
`abstract`, `getVectorValues`)in the base class, this makes every subclass to
take decision forcibly on implementing and completing these functions which may
be better than just implementing the default.
But if we want to make this as default implementation, this needs to change
across all three vector encoding not just Float16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
