Pulkitg64 commented on PR #16383: URL: https://github.com/apache/lucene/pull/16383#issuecomment-5107312014
Hi @uschindler > I would need help with writing the actual panama vector code for Java 27, so if you have a mockup for the methods currently unimplemented, please point me to it so I can do copypaste. This it complete commit which has changes to Panama class which I did for testing fp16 vector related operations: [Commit Link](https://github.com/apache/lucene/pull/15549/changes/6599f80af6b78412fc80e79711ceea8a0c59c1eb#diff-de8cf25ec7be20476df8d0097309c2243f20a52004e95072f13924901d3942be), [Panama class with Float16 vector operations](https://github.com/Pulkitg64/lucene/blob/6599f80af6b78412fc80e79711ceea8a0c59c1eb/lucene/core/src/java25/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java) > Please decide where it should stay (I'd favour Lucene 11 only, because this is containing too much new and modified code). Therefore I am negative to backporting (also with regards to JDK 27 support) I don't have any strong opinion on this. Though I don't expect this change to bring many conflict on 10.x branch so maybe its fine to backport the changes. But I am planning to introduce quantization support for FP16 in a separate PR, I think that can bring some conflicts so that change can go to 11.0. So I am not sure if it is fine to push both changes on different branch or not(i.e FP16 support on 10.6 but quantization support on 11.0). I can raise a backport PR if you think backport this change is fine otherwise I will move the entry in CHANGES.txt from 10.6 to 11.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
