ChrisHegarty commented on code in PR #16418:
URL: https://github.com/apache/lucene/pull/16418#discussion_r3664796688
##########
lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java:
##########
@@ -90,6 +90,12 @@ public class LiveIndexWriterConfig {
/** True if calls to {@link IndexWriter#close()} should first do a commit. */
protected boolean commitOnClose = IndexWriterConfig.DEFAULT_COMMIT_ON_CLOSE;
+ /** True if set-only doc-values updates are written as sparse delta
generations. */
+ protected volatile boolean incrementalDocValuesUpdates;
Review Comment:
does this need to be volatile? Both settings are declared volatile, meaning
they can be changed at runtime on a running IndexWriter. But
`setIncrementalDocValuesUpdates` says "Only takes effect when IndexWriter is
first created". Unless I'm missing something then the volatile can just be
dropped!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
