ChrisHegarty commented on PR #16418: URL: https://github.com/apache/lucene/pull/16418#issuecomment-5103172745
The conditional version bump in `SegmentInfos.write()` (only bump to `VERSION_11_0` when overlays are active, otherwise write `VERSION_86`) is clever, but makes compatibility dependent on merge timing rather than config. The same index with the same settings might be readable by old Lucene after a merge flattens everything, then unreadable again when new updates land. That feels a bit fragile; whether a rollback to an older version works depends on whether merges have kept up, which isn't something operators typically control or reason about. Might be simpler to just always write `VERSION_11_0` when the feature is enabled, so compatibility is deterministic based on config alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
