uschindler commented on PR #16431: URL: https://github.com/apache/lucene/pull/16431#issuecomment-5118192316
> I don't see how you can " guarantee[s] zero correctness bugs " - sounds like a statement from an overambitious AI! > > In particular, if someone implements a scoring function like `sin()` and provides its maximum (== 1); won't that cause scoring bugs? I understood it like this: The default is to use INFINITY when returning if it is maxScore ready. If you implement a sinus function and implement maxScore for it, it would break. But then it's your own problem, because you implemented maxScore support for it. What I did not yet undertsood: Where are the defaults (increasing/decreasing) as in the statement above for `-x`, `x`, `sqrt(x)`....? Can we have an example and a test for a "homemade" function that followins decreasing or increasing logic? I want this to be defined together with the function! The caller who constructs a FunctionQuery should not need to kown if the function heshe uses is increasing! What happens if you use a ValueSource with an increasing function and you wrap it with another decreasing function (nesting)? There should be clear paths so it is also safe for the user. Otherwise I would be against such an optimization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
