uschindler commented on code in PR #16431:
URL: https://github.com/apache/lucene/pull/16431#discussion_r3676434717
##########
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##########
@@ -46,6 +47,16 @@
*/
public abstract class DoubleValuesSource implements SegmentCacheable {
+ /** Monotonicity direction of a decoder function */
+ public enum Monotonicity {
+ /** Increasing function */
+ INCREASING,
Review Comment:
I don't like to have "NON" in the name, this makes it hard to use.
INCREASING should be fine, because unless it is strictly increasing it means
that the values go up. A constant function is fine, you should be able to
chooseany of INCREASING or DECREASING, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
