mikemccand commented on code in PR #15979: URL: https://github.com/apache/lucene/pull/15979#discussion_r3691217160
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/codecs/dedup/DedupGroup.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.codecs.lucene106.dedup; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import org.apache.lucene.internal.hppc.LongIntHashMap; +import org.apache.lucene.internal.hppc.ObjectCursor; +import org.apache.lucene.util.Accountable; + +/** Review Comment: >, perhaps we can make [this method](https://github.com/kaivalnp/lucene/blob/4052a01e6b1bf0bcc78d1aec9a28ace464103352/lucene/core/src/test/org/apache/lucene/codecs/lucene106/dedup/TestDedupFlatVectorsFormat.java#L251-L254) `public` from the de-duplicating HNSW format? +1, but we should waiting until / when / if this format is in `core` module. `CheckIndex` could then do `instanceof` + cast check and print more details. Hmm but is that method field specific? Or its for all groups across all fields that share this dedup instance? Beyond printing useful stats, we should also fix `CheckIndex` to validate any integrity beyond what its current vector checks exercise. E.g. if there is an API that says how many unique vectors this field has maybe `Checkindex` could count as it iterates vectors for that field and see if they agree, or so. But all of this dreamy stuff is for later! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
