[
https://issues.apache.org/jira/browse/SUREFIRE-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15779839#comment-15779839
]
ASF GitHub Bot commented on SUREFIRE-1309:
------------------------------------------
GitHub user sverhagen opened a pull request:
https://github.com/apache/maven-surefire/pull/138
SUREFIRE-1309: Clarifying use of regular expressions for inclusion/exclusion
Added clarification to site examples, as discussed in
[SUREFIRE-1309](https://issues.apache.org/jira/browse/SUREFIRE-1309).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sverhagen/maven-surefire SUREFIRE-1309
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #138
----
commit 85d7af0bfca1268e62f0902ec70f22370cd3dcf6
Author: Sander Verhagen <sverha...@jamasoftware.com>
Date: 2016-12-27T07:39:56Z
SUREFIRE-1309: Clarifying use of regular expressions for inclusion/exclusion
----
> Clarify %regex
> --------------
>
> Key: SUREFIRE-1309
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1309
> Project: Maven Surefire
> Issue Type: Documentation
> Affects Versions: 2.19.1
> Environment: Probably any environment
> Reporter: Sander Verhagen
> Assignee: Tibor Digana
>
> It would be good to clarify the {{%regex ...}} feature:
> 1. While it is said to be regular expression, it really is a {{regular
> expression + ".class"}} kind of thing. This does not work (while it is proper
> regex):
> {noformat}.+\.class{noformat} The following works (while it is not proper
> regex): {noformat}.+.class{noformat}
> 2. Clarify that one is supposed to match slashes between packages and class
> name, not periods. The following [current
> documentation|http://maven.apache.org/components/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html]
> doesn't clarify that by just using "{{.*}}":
> {noformat}!%regex[pkg.*Slow.*.class]{noformat}
> 3. Clarify what the expectations are in terms of escaping characters
> I just spend literally ten hours figuring out a complex regex, going into
> TeamCity (which by itself complicated the troubleshooting for me), and the
> documentation could have saved my butt, here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
