[ 
https://issues.apache.org/jira/browse/SUREFIRE-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784885#comment-15784885
 ] 

ASF GitHub Bot commented on SUREFIRE-1309:
------------------------------------------

Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/138
  
    @sverhagen 
    Thx for contributing. This PR was merged. Pls close it.


> Clarify %regex
> --------------
>
>                 Key: SUREFIRE-1309
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1309
>             Project: Maven Surefire
>          Issue Type: Documentation
>    Affects Versions: 2.19.1
>         Environment: Probably any environment
>            Reporter: Sander Verhagen
>            Assignee: Tibor Digana
>             Fix For: 2.19.2
>
>
> It would be good to clarify the {{%regex ...}} feature:
> 1. While it is said to be regular expression, it really is a {{regular 
> expression + ".class"}} kind of thing. This does not work (while it is proper 
> regex):
> {noformat}.+\.class{noformat} The following works (while it is not proper 
> regex): {noformat}.+.class{noformat}
> 2. Clarify that one is supposed to match slashes between packages and class 
> name, not periods. The following [current 
> documentation|http://maven.apache.org/components/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html]
>  doesn't clarify that by just using "{{.*}}": 
> {noformat}!%regex[pkg.*Slow.*.class]{noformat}
> 3. Clarify what the expectations are in terms of escaping characters
> I just spend literally ten hours figuring out a complex regex, going into 
> TeamCity (which by itself complicated the troubleshooting for me), and the 
> documentation could have saved my butt, here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to