[ 
https://issues.apache.org/jira/browse/MSHADE-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833135#comment-15833135
 ] 

Robert Scholte commented on MSHADE-240:
---------------------------------------

Your situation is exactly the opposite of my usecase. In my case it must find 
the version of a certain dependency, no matter shaded or not. So it all depends 
on the implementation, hence it is up to the developer to decide if these files 
should be relocated or not.

> support relocation pom.properties and pom.xml descriptors in shaded jars
> ------------------------------------------------------------------------
>
>                 Key: MSHADE-240
>                 URL: https://issues.apache.org/jira/browse/MSHADE-240
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.4.3
>            Reporter: Thomas Mortagne
>            Assignee: Robert Scholte
>             Fix For: 3.0.0
>
>
> When using shade plugin to embbed (and relocate to be safe) some dependency 
> the final jar ends up with the dependency 
> {{/META-INF/maven/<groupid>/<artifactid>/*}} files.
> The problem is that in the final jars those files essentially become a lie 
> for any tools looking at those descriptors to find out what the jar contains 
> and you end up with false positive.
> Ideally they should be stripped when relocating a dependency since it means 
> the jar does not contain what is indicated in those files anymore, only 
> something that happen to have the same feature but with completely different 
> packages (so unusable). An alternative is to move them in some other place 
> like {{/META-INF/shade/maven/<groupid>/<artifactid>/*}} for example, so that 
> you still keep information about what has been shaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to