[ 
https://issues.apache.org/jira/browse/MSHADE-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832178#comment-15832178
 ] 

Thomas Mortagne commented on MSHADE-240:
----------------------------------------

bq. I haven't activated it by default

Would have been nice. Most of the issues I have are with dependencies I don't 
control on and which don't care about those files so they will never thing 
about enabling this.

> support relocation pom.properties and pom.xml descriptors in shaded jars
> ------------------------------------------------------------------------
>
>                 Key: MSHADE-240
>                 URL: https://issues.apache.org/jira/browse/MSHADE-240
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.4.3
>            Reporter: Thomas Mortagne
>            Assignee: Robert Scholte
>             Fix For: 3.0.0
>
>
> When using shade plugin to embbed (and relocate to be safe) some dependency 
> the final jar ends up with the dependency 
> {{/META-INF/maven/<groupid>/<artifactid>/*}} files.
> The problem is that in the final jars those files essentially become a lie 
> for any tools looking at those descriptors to find out what the jar contains 
> and you end up with false positive.
> Ideally they should be stripped when relocating a dependency since it means 
> the jar does not contain what is indicated in those files anymore, only 
> something that happen to have the same feature but with completely different 
> packages (so unusable). An alternative is to move them in some other place 
> like {{/META-INF/shade/maven/<groupid>/<artifactid>/*}} for example, so that 
> you still keep information about what has been shaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to