[ 
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896103#comment-15896103
 ] 

Marc Campbell commented on DOXIA-554:
-------------------------------------

My understanding is:

1. `doxia-module-markdown` version can be specified separately from other Doxia 
modules.

{code:xml}
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-site-plugin</artifactId>
    <version>${maven-site-plugin.version}</version>
    <dependencies>
        <dependency>
            <groupId>org.apache.maven.doxia</groupId>
            <artifactId>doxia-module-markdown</artifactId>
            <version>${doxia-module-markdown.version}</version>
        </dependency>
    </dependencies>
</plugin>
{code}

2. The `pegdown` used `doxia-module-markdown` 1.7 is broken. This issue 
`DOXIA-554` is one of many such examples. (see 3.)

3. The `pegdown` used `doxia-module-markdown` 1.7 is is expressly EOL.  There 
are no plans to fix the broken `pegdown` issue

--> https://github.com/sirthias/pegdown/

{quote}
The (_pegdown_) project is essentially unmaintained with tickets piling up and 
crucial bugs not being fixed.

_pegdown_'s parsing performance isn't great. In some cases of pathological 
input runtime can even become exponential, which means that the parser either 
appears to "hang" completely or abort processing after a time-out.
{quote}

4. The `pegdown` project README also gives several proactive reasons to switch 
to `flexmark-java` including: 

--> https://github.com/sirthias/pegdown/

{quote}
* Modern parser architecture (based on commonmark-java), designed from the 
ground up as a pegdown replacement and supporting all its features and 
extensions
* 30x better average parsing performance without pathological input cases
* Configuration options for a multitude of markdown dialects (CommonMark, 
pegdown, MultiMarkdown, kramdown and Markdown.pl)
{quote}

Proposed Solution:

A. Keep a `doxia-module-markdown` v1.7.x with the broken `pegdown` for extended 
support Java 6 users.

B. Have a newer, working `doxia-module-markdown` version with `flexmark-java` 
and Java 7 so users actually have a non-broken option.

C. Clearly document the version choice on the `doxia-module-markdown` pages so 
maven user can choose for themselves.

--> https://maven.apache.org/doxia/doxia/doxia-modules/doxia-module-markdown/

Is the above both (1) a sufficiently clear justification to allow a 
flexmark-java version to be submitted and (2) a non-conflicted approach which 
can support both legacy, on-paid extended arrangement Java 6, Maven 3.0 users 
and more up-to-date public supported Java 7, Maven 3.3+ users? 

Please.. yes?

> Parsing time for Markdown documents can take very long and hang site 
> generation
> -------------------------------------------------------------------------------
>
>                 Key: DOXIA-554
>                 URL: https://issues.apache.org/jira/browse/DOXIA-554
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Module - Markdown
>    Affects Versions: 1.7
>            Reporter: Michael Benz
>         Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site 
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since 
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to 
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial 
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological 
> input runtime can even become exponential, which means that the parser either 
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to 
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to