[ http://jira.codehaus.org/browse/MECLIPSE-139?page=comments#action_76853 ]
Kenney Westerhof commented on MECLIPSE-139:
-------------------------------------------
Hi,
Thanks for the patch, but a few comments:
- Could you please sync it with the current trunk? I know we slacked a bit,
sorry for the extra work.
- Also normally 'svn diff' would give you a diff from the current dir down,
this one includes absolute paths. No problem though, since patch -p7 should
do the job but the patch didn't take. Could you please make sure future patches
are rooted in the project(s) where they apply to?
- Please remove unnecessary changes that don't touch lines you change. I saw
some reformatting there,
and it obfuscates the readability of the patch. Also make sure you use
spaces, not tabs:
{noformat}
@@ -202,8 +211,8 @@
{
testProject( "project-21" );
}
-
- /**
+
+ /**
* PDE support using eclipse-plugin packaging.
* @throws Exception any exception thrown during test
*/
{noformat}
And reformatting of commented out code:
@@ -141,30 +146,31 @@
testProject( "project-15", props );
}
{noformat}
- //Commented out: failing due to MNG-2025
- // /**
- // * UTF8 encoding - MECLIPSE-56
- // * @throws Exception any exception thrown during test
- // */
[snip]+ // Commented out: failing due to MNG-2025
+ // /**
+ // * UTF8 encoding - MECLIPSE-56
+ // * @throws Exception any exception thrown during test
+ // */
{noformat}
- Please separate patches for different features; your last patch also includes
code that doesn't relate to
this issue at all.
I know it's tempting to refactor lots of stuff when you're working on it, but
we need to clearly see
what has changed and what it does. A patch like this makes this very hard.
Please only modify those lines
that affect the issue at hand.
I just ran into this issue myself, and I'll apply as soon as you attach another
patch.
Thanks a lot!
> Eclipse plugin cannot handle Java source files in resource directories
> ----------------------------------------------------------------------
>
> Key: MECLIPSE-139
> URL: http://jira.codehaus.org/browse/MECLIPSE-139
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Affects Versions: 2.3
> Reporter: Jochen Kuhnle
> Fix For: 2.3
>
> Attachments: MECLIPSE-139-java-resources.patch,
> MECLIPSE-139-java-resources.patch, MECLIPSE-139-java-resources.patch
>
>
> The eclipse plugin cannot handle Java source files in resource directories:
> The resulting Eclipse configuration compiles the Java files, so the target
> directory contains the class files, but not the java sources.
> This is often troublesome in unit tests or when you need to use code
> templates, because you often get compile errors in the Workbench. The
> attached plugin allows to handle this situation in the following ways:
> 1. Default behavior: Work just as the plugin did before
> 2. Exclude Java files from resource dirs
> 3. Use an Ant builder to copy Java sources
> As a sideeffect, the patch also extends the handling of custom builders:
> Instead of just specifying a name, you can also specify the triggers and
> arguments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
