[ 
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283907#comment-16283907
 ] 

ASF GitHub Bot commented on SUREFIRE-1372:
------------------------------------------

Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/150
  
    As far as I remember the filter was used in rerun feature where broken
    tests were executed several more times after.
    Yet let me check your branch because that's better than if you spent your
    time again.
    I will inform you about my findings in few days.
    
    On Fri, Dec 8, 2017 at 5:07 PM, M.P. Korstanje <notificati...@github.com>
    wrote:
    
    > @Tibor17 <https://github.com/tibor17> It appears this branch is still up
    > to date with master.
    >
    > Is the removal of the class the problem or the underlying fundamentals? If
    > it is just the removal I can restore FailingMethodFilter.java. It went
    > unused after my changes. If it is the underlying fundamentals please let 
me
    > know how I can help you.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > 
<https://github.com/apache/maven-surefire/pull/150#issuecomment-350301256>,
    > or mute the thread
    > 
<https://github.com/notifications/unsubscribe-auth/AA_yR4f-4bf3vz9RkLIyf-k7OEB7VA4Kks5s-V6rgaJpZM4NoCQj>
    > .
    >
    
    
    
    -- 
    Cheers
    Tibor



> Rerunning failing tests fails in combination with 
> Description#createSuiteDescription
> ------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1372
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1372
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.20
>            Reporter: M.P. Korstanje
>            Assignee: Tibor Digana
>             Fix For: 2.21.1
>
>
> When using surefire to rerun failing tests created by a Runner that uses 
> {noformat}Description#createSuiteDescription{noformat} with a human readable 
> name rather then a class name the following stack trace occurs:
> {code}
> org.apache.maven.surefire.testset.TestSetFailedException: Unable to create 
> test class 'Scenario: Fail when running'
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:385)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> Caused by: java.lang.ClassNotFoundException: Scenario: Fail when running
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:379)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:292)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
>         at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to