[GitHub] michael-o commented on a change in pull request #74: [SCM-885] third implementation

[GitBox]

michael-o commented on a change in pull request #74: [SCM-885] third 
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381286
 
 

 ##########
 File path: 
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java
 ##########
 @@ -82,12 +82,14 @@ protected ChangeLogScmResult executeChangeLogCommand( 
ScmProviderRepository repo
         throws ScmException
     {
         Git git = null;
+        boolean isARangeChangeLog = startVersion != null || endVersion != null;
 
 Review comment:
   Isn't this name inconsistent with the gitexe provider?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services