michael-o commented on a change in pull request #74: [SCM-885] third implementation URL: https://github.com/apache/maven-scm/pull/74#discussion_r189381570
########## File path: maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/AbstractChangeLogCommand.java ########## @@ -76,13 +84,21 @@ public ScmResult executeCommand( ScmProviderRepository repository, ScmFileSet fi ScmBranch branch = (ScmBranch) parameters.getScmVersion( CommandParameter.BRANCH, null ); + ScmVersion version = parameters.getScmVersion( CommandParameter.SCM_VERSION, null ); + ScmVersion startVersion = parameters.getScmVersion( CommandParameter.START_SCM_VERSION, null ); ScmVersion endVersion = parameters.getScmVersion( CommandParameter.END_SCM_VERSION, null ); String datePattern = parameters.getString( CommandParameter.CHANGELOG_DATE_PATTERN, null ); - if ( startVersion != null || endVersion != null ) + boolean fromVersionToStartOfRepository = startVersion == null && endVersion == null && version != null; + + if (fromVersionToStartOfRepository) Review comment: spaces please ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services