michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274131823
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -829,13 +831,13 @@ private boolean validateId( String fieldName,
ModelProblemCollector problems, Se
}
else
{
- boolean match = ID_REGEX.matcher( id ).matches();
- if ( !match )
+ if ( !org.apache.commons.lang3.StringUtils.containsOnly( id,
ID_CHARS ) )
{
addViolation( problems, severity, version, fieldName,
sourceHint,
"with value '" + id + "' does not match a valid
id pattern.", tracker );
Review comment:
This message does not reflect the issue anymore because we don't have any
anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
