michael-o commented on a change in pull request #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#discussion_r274133797
########## File path: maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java ########## @@ -204,19 +211,33 @@ public final void parseVersion( String version ) } private static Integer getNextIntegerToken( StringTokenizer tok ) + { + String s = tok.nextToken(); + if ( ( s.length() > 1 ) && s.startsWith( "0" ) ) + { + return null; + } + return tryParseInt( s ); + } + + private static Integer tryParseInt( String s ) { try { - String s = tok.nextToken(); - if ( ( s.length() > 1 ) && s.startsWith( "0" ) ) + if ( !isParsable( s ) ) + { + return null; + } + long longValue = Long.parseLong( s ); + if ( longValue > Integer.MAX_VALUE ) Review comment: Again, change in semantics with long. Dislike on this one. Why all the hassle, why not use `NumberUtils` from Commons Lang 3? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services