oehme commented on a change in pull request #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#discussion_r274159867
########## File path: maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java ########## @@ -150,6 +150,30 @@ public int compareTo( Item item ) } } + @Override + public boolean equals( Object o ) Review comment: Because it wouldn't safe any code here, as nothing is nullable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services