oehme commented on a change in pull request #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#discussion_r274317574
########## File path: maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java ########## @@ -211,6 +235,30 @@ public int compareTo( Item item ) } } + @Override + public boolean equals( Object o ) + { + if ( this == o ) + { + return true; + } + if ( o == null || getClass() != o.getClass() ) + { + return false; + } + + LongItem longItem = (LongItem) o; + + return value == longItem.value; + + } + + @Override + public int hashCode() Review comment: What for? It's a single object, not a list. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services