suztomo commented on a change in pull request #39: [MRESOLVER-93] -
PathRecordingDependencyVisitor to handle 3 cycles
URL: https://github.com/apache/maven-resolver/pull/39#discussion_r316131184
##########
File path:
maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/visitor/PathRecordingDependencyVisitorTest.java
##########
@@ -141,12 +141,12 @@ public void testGetPaths_HandlesCycles_threePaths()
{
DependencyNode root = parse( "cycle-3paths.txt" );
- PathRecordingDependencyVisitor visitor = new
PathRecordingDependencyVisitor( new ArtifactMatcher(), false );
+ PathRecordingDependencyVisitor visitor = new
PathRecordingDependencyVisitor( new ArtifactMatcher() );
root.accept( visitor );
List<List<DependencyNode>> paths = visitor.getPaths();
- assertEquals( paths.toString(), 4, paths.size() );
- assertPath( paths.get( 0 ), "a", "b", "c");
+ assertEquals( paths.toString(), 1, paths.size() );
Review comment:
> Changed unit test indicates modified behavior of the impl unexpectedly.
This unit test takes a new input `cycle-3paths.txt`, thus the expected
output is different than the one above. The unit test above
(`testGetPaths_HandlesCycles` with `cycle.txt`) is unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
