suztomo commented on a change in pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles URL: https://github.com/apache/maven-resolver/pull/39#discussion_r316202790
########## File path: maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/PathRecordingDependencyVisitor.java ########## @@ -101,6 +96,7 @@ public boolean visitEnter( DependencyNode node ) { boolean accept = filter == null || filter.accept( node, parents ); + boolean hasDuplicateNodeInParent = parents.contains( node ); Review comment: @belingueres In PR summary, I just added explanation on why I now think `parent.contains(node)` performance should not be a problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services