kriegaex commented on a change in pull request #332: URL: https://github.com/apache/maven-surefire/pull/332#discussion_r564955600
########## File path: maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporterTest.java ########## @@ -380,7 +381,7 @@ public void testSyncOnDeferredFile() throws Exception { Utf8RecodingDeferredFileOutputStream out = new Utf8RecodingDeferredFileOutputStream( "test" ); ByteBuffer cache = ByteBuffer.wrap( new byte[] {1, 2, 3} ); - cache.position( 3 ); + ( (Buffer) cache ).position( 3 ); Review comment: I checked all tests and also all application code by manually flipping local `ByteBuffer` variables to `Buffer`, and this is the only place where this is actually possible. In all other places one of the following stops me from easily changing `ByteBuffer` into `Buffer` types: * Other `ByteBuffer` methods are being used, requiring casts in the reverse direction to `ByteBuffer`. * The variable is declared as a method parameter, requiring signature changes, possibly recursively. * The variable is used in method calls requiring a cast in reverse direction to `ByteBuffer`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org