kriegaex commented on pull request #332:
URL: https://github.com/apache/maven-surefire/pull/332#issuecomment-767947574
> Maybe you want to contribute instead of micro-managing my edits? 😉
After having checked all your code review suggestions plus all the other
places I changed which you did not even mention, my assumption that
collaboratively working on this would have saved time. If you had just checked
out the PR and tried to flip types in your IDE, you would have noticed. I think
that code reviews outside of an IDE which actually compiles are not
particularly helpful in this case where it is about changing types in order to
avoid casting. So - no offence meant - this was a waste of time for both of us
and I want to re-invite you to piggy-back on my PR and just commit whatever
improvements you have for it. Before you even write "could you edit this like
that?", you would have done it already with no more time spent but without me
spending time on checking, commenting back, you reading the comments again.
We could
* avoid micro-management,
* save time,
* get better code faster,
* avoid some of the 7 wastes of lean production, such as hand-offs,
stretching the cycle time by scattering the touch times across a longer than
necessary time frame. You are a busy developer and doing OSS in your spare
time, I assume. Even if someone pays you for it, you do not want to create
waste.
Sorry for lobbying here and making this a general discussion, but I always
do that when contributing to a project for the first time in order to find out
if it would be attractive for me to contribute again in the future. I am
strictly against the policy in so many OSS projects that PRs get micro-managed
in many iterations up to the point in which the contributor has shaped the code
into something the reviewer would have written. Better to accept an imperfect,
but valuable PR and help polishing it by yourself. Then the chances are much
higher that the code ends up thhe way you like it as a maintainer. Also, the
contributor can learn from the edits. Win-win.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
