kriegaex edited a comment on pull request #108: URL: https://github.com/apache/maven-shade-plugin/pull/108#issuecomment-883805845
Because the new PR has no description, I want to quickly describe it: It solves [MSHADE-366](https://issues.apache.org/jira/browse/MSHADE-366) in a more fundamental way than both #83 and #104, namely by adding the new feature of handling input directories and input JARs uniformly with regard to service provider minification, instead of simply avoiding to log irritating warnings when directories - most prominently, the own module's `target/classes` - are found on the classpath. It addresses the then open question I raised in https://github.com/apache/maven-shade-plugin/pull/83#issuecomment-847452890, in my [MSHADE-366 comment](https://issues.apache.org/jira/browse/MSHADE-366?focusedCommentId=17350709&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17350709) and again in https://github.com/apache/maven-shade-plugin/pull/104#issuecomment-873361152 as a reaction to @rmannibucau's corresponding question. Therefore, this PR supersedes both of its predecessors. I am suggesting to finish it ASAP (if Romain thinks he still needs to change/improve anything), so we can review and merge it, then get it into a hopefully soon to be released Shade 3.3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
