kriegaex commented on pull request #108:
URL:
https://github.com/apache/maven-shade-plugin/pull/108#issuecomment-883823450
Sorry, I was a bit too fast with my enthusiasm: In its current state, this
PR improves `DefaultShader`, but MSHADE-366 is about minification and the
previous two PRs addressed warnings in `MinijarFilter`. I.e., while Romain's
changes point the way towards unified file handling for directories and JARs,
it is by no means used during minification yet. The old warning persists.
To do:
* Unify resource handling in `MinijarFilter`
* Refactor method `MinijarFilter.removeService` in a way similar to how I
did it in PR 104, commit
https://github.com/apache/maven-shade-plugin/pull/104/commits/faa97dfb202f56bd5ddff7e0e717f695f956aeb1,
extracting smaller methods from that big one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
