gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064078828
> This does not supersede [e327be3](https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7) but complements it? Yes, I actually don't think the first commit is really relevant or useful with the current fix. I think in most cases, only the top level project has a classloader, which means the previous commit won't actually do anything and the classloader will remain the same. The problem is that I don’t think the behavior is defined for the “scope” of such extensions for reactor builds. My assumption is that they are defined on the top level project and should be available for the whole execution, hence the fix that registers the top level project classloader… a bit earlier in the maven execution. So, I guess the answer should be yes ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
