hboutemy commented on a change in pull request #73: URL: https://github.com/apache/maven-plugin-tools/pull/73#discussion_r824427199
########## File path: maven-plugin-plugin/src/it/mplugin-394_report-encoding/invoker.properties ########## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +invoker.goals = -Dfile.encoding=CP1252 plugin:report Review comment: honestly, we don't really write ITs for such encoding issues: there is no chance of regression at plugin level, only base encoding-aware XML reading class is well tested so IMHO, don't worry too much, eventually remove the IT that was done if it's not useful: it was done based on good principles, but life is life on such feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
