Tibor17 commented on a change in pull request #487:
URL: https://github.com/apache/maven-surefire/pull/487#discussion_r824618154
##########
File path: surefire-providers/surefire-junit-platform/pom.xml
##########
@@ -136,6 +136,47 @@
</includes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>api-jar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ <configuration>
+ <classifier>api</classifier>
Review comment:
This looks like a hack. Why you have introduced Apache SPI and you
change the default behavior this way? JUnit5 SPI do not exist with same
purpose? The plugin has configuration of class/methods. If somebody changes
this in the SPI, then what you be valid? Configuration or SPI? **Pls describe
very properly what you are aiming for in the JIRA in details.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
