[
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540389#comment-17540389
]
ASF GitHub Bot commented on SCM-979:
------------------------------------
cstamas commented on code in PR #143:
URL: https://github.com/apache/maven-scm/pull/143#discussion_r878674102
##########
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java:
##########
@@ -60,7 +63,8 @@
private SecDispatcher secDispatcher;
- protected void setUp()
+ @Override
+ public void setUp()
Review Comment:
fixed
##########
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##########
@@ -135,10 +138,9 @@ public void removeRepo()
/**
* Provided to allow removeRepo() to be called.
- * @see junit.framework.TestCase#tearDown()
*/
@Override
- protected void tearDown()
+ public void tearDown()
Review Comment:
fixed
> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
> Key: SCM-979
> URL: https://issues.apache.org/jira/browse/SCM-979
> Project: Maven SCM
> Issue Type: Task
> Reporter: Michael Osipov
> Assignee: Tamás Cservenák
> Priority: Major
> Fix For: 2.0.0-M2
>
>
> Changes:
> * make project Java8
> * update dependencies accordingly
> * remove any uses of deprecated Plexus APIs
> * replace plexus-container-default with plexus-shim
> * replace/drop PlexusLogger/ScmLogger and use SLF4J API
> * replace use of Junit3 PlexusTestCase with Junit4 (make possible use of
> Assume)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
