[
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540395#comment-17540395
]
ASF GitHub Bot commented on SCM-979:
------------------------------------
cstamas commented on code in PR #143:
URL: https://github.com/apache/maven-scm/pull/143#discussion_r878674333
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/remoteinfo/JGitRemoteInfoCommandTckTest.java:
##########
@@ -29,6 +29,8 @@
import org.apache.maven.scm.provider.git.repository.GitScmProviderRepository;
import org.eclipse.jgit.util.FileUtils;
+import static org.junit.Assert.assertEquals;
Review Comment:
In junit3 you inherited this method (w/ same signature from TestCase), but
in Junit4 you need to use hamcrest, or Assert or alike, hence static import but
no other change (as method sig is same).
##########
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTckTest.java:
##########
@@ -24,6 +24,8 @@
import
org.apache.maven.scm.provider.svn.command.remoteinfo.AbstractSvnRemoteInfoCommandTckTest;
import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+import static org.junit.Assert.assertTrue;
Review Comment:
In junit3 you inherited this method (w/ same signature from TestCase), but
in Junit4 you need to use hamcrest, or Assert or alike, hence static import but
no other change (as method sig is same).
> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
> Key: SCM-979
> URL: https://issues.apache.org/jira/browse/SCM-979
> Project: Maven SCM
> Issue Type: Task
> Reporter: Michael Osipov
> Assignee: Tamás Cservenák
> Priority: Major
> Fix For: 2.0.0-M2
>
>
> Changes:
> * make project Java8
> * update dependencies accordingly
> * remove any uses of deprecated Plexus APIs
> * replace plexus-container-default with plexus-shim
> * replace/drop PlexusLogger/ScmLogger and use SLF4J API
> * replace use of Junit3 PlexusTestCase with Junit4 (make possible use of
> Assume)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
