michael-o commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060327152
########## api/maven-api-model/pom.xml: ########## @@ -63,26 +63,26 @@ under the License. </executions> </plugin> <plugin> - <groupId>org.apache.maven</groupId> - <artifactId>modello-plugin-velocity</artifactId> - <configuration> - <version>4.2.0</version> - <models> - <model>src/main/mdo/maven.mdo</model> - </models> - <templates> - <template>src/main/mdo/model.vm</template> - </templates> - <params> - <param>packageModelV4=org.apache.maven.api.model</param> - </params> - </configuration> + <groupId>org.codehaus.modello</groupId> + <artifactId>modello-maven-plugin</artifactId> <executions> <execution> - <id>modello</id> + <id>velocity</id> <goals> <goal>velocity</goal> </goals> + <configuration> + <version>4.2.0</version> + <models> + <model>src/main/mdo/maven.mdo</model> + </models> + <templates> + <template>src/main/mdo/model.vm</template> + </templates> Review Comment: What is the purpose of having those models in `main` if we will never distinct between `main` and `test`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org