hboutemy commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060691858
########## api/maven-api-model/pom.xml: ########## @@ -63,26 +63,26 @@ under the License. </executions> </plugin> <plugin> - <groupId>org.apache.maven</groupId> - <artifactId>modello-plugin-velocity</artifactId> - <configuration> - <version>4.2.0</version> - <models> - <model>src/main/mdo/maven.mdo</model> - </models> - <templates> - <template>src/main/mdo/model.vm</template> - </templates> - <params> - <param>packageModelV4=org.apache.maven.api.model</param> - </params> - </configuration> + <groupId>org.codehaus.modello</groupId> + <artifactId>modello-maven-plugin</artifactId> <executions> <execution> - <id>modello</id> + <id>velocity</id> <goals> <goal>velocity</goal> </goals> + <configuration> + <version>4.2.0</version> + <models> + <model>src/main/mdo/maven.mdo</model> + </models> + <templates> + <template>src/main/mdo/model.vm</template> + </templates> Review Comment: 1. it has been our convention for ever https://github.com/apache/maven/tree/maven-3.9.x/maven-model/src/main/mdo 2. it's really main code that it generated, then storing in `src/main` makes sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org