[
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730932#comment-17730932
]
ASF GitHub Bot commented on MASSEMBLY-791:
------------------------------------------
elharo commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1224195808
##########
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##########
@@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+ /**
+ * Override of umask.
Review Comment:
Now that I see the description, does it even matter that this overrides
another value? It would be simpler to just say this sets the umask directly,
and also specify the default value used if one is not specified here. The rest
is implementation detail.
##########
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##########
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+ /**
+ * @return Override umask.
Review Comment:
Consistency with existing incomplete code is not a virtue.
##########
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##########
@@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource {
* @return Override group name.
*/
String getOverrideGroupName();
+
+ /**
+ * @return Override umask.
+ */
+ Integer getOverrideUmask();
Review Comment:
You never know who your dependents are. It's easy to add a return null here,
and then you don't break anyone.
> fileMode not set in dependencySet creating format tar.gz
> --------------------------------------------------------
>
> Key: MASSEMBLY-791
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: permissions
> Affects Versions: 2.6
> Environment: Linux and Windows
> Reporter: Rick Poleshuck
> Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz
> archive. This works just fine in 2.4.
> <dependencySets>
> <dependencySet>
> <includes>
> <include>com.company:dependency-artifact</include>
> </includes>
> <unpack>true</unpack>
> <unpackOptions>
> <includes>
> <include>*.py</include>
> </includes>
> </unpackOptions>
> <outputDirectory/>
> <fileMode>0750</fileMode>
> <directoryMode>0750</directoryMode>
> </dependencySet>
> </dependencySets>
> </
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
