[ 
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740197#comment-17740197
 ] 

ASF GitHub Bot commented on MASSEMBLY-791:
------------------------------------------

mabrarov commented on code in PR #148:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253076754


##########
src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java:
##########
@@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource {
      * @return Override group name.
      */
     String getOverrideGroupName();
+
+    /**
+     * @return Mask which is applied to permissions of files/directories 
before they are put into assembly.

Review Comment:
   Sorry, do you mean changing of case (**m**ask)? It looks like documentation 
for all over methods with `@return` Javadoc starts from upper case after 
`@return` statement. Is it OK to not follow existing formatting in this case?





> fileMode not set in dependencySet creating format tar.gz
> --------------------------------------------------------
>
>                 Key: MASSEMBLY-791
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
>             Project: Maven Assembly Plugin
>          Issue Type: Bug
>          Components: permissions
>    Affects Versions: 2.6
>         Environment: Linux and Windows
>            Reporter: Rick Poleshuck
>            Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz 
> archive. This works just fine in 2.4.
>     <dependencySets>
>         <dependencySet>
>             <includes>
>                 <include>com.company:dependency-artifact</include>
>             </includes>
>             <unpack>true</unpack>
>             <unpackOptions>
>                 <includes>
>                     <include>*.py</include>
>                 </includes>
>             </unpackOptions>
>             <outputDirectory/>
>             <fileMode>0750</fileMode>
>             <directoryMode>0750</directoryMode>
>         </dependencySet>
>     </dependencySets>
> </ 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to