[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740194#comment-17740194 ]
ASF GitHub Bot commented on MASSEMBLY-791: ------------------------------------------ mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253072332 ########## src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java: ########## @@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends AbstractMojo implements Assem @Parameter private String overrideGroupName; + /** + * Override of umask. Review Comment: Changed to ```java /** * Mask which is applied to permissions of files/directories before they are put into assembly. * If {@code null} then the mask is not explicitly configured and remains implementation-specific. */ ``` When this option is not configured (`null`), then the umask remains Plexus Archiver implementation detail (which I know is `022`, but I cannot put it into documentation of `overrideUmask` configuration option of Maven Assembly Plugin). IMHO, we can not put `022` as default value of `overrideUmask` configuration option of Maven Assembly Plugin, because it breaks backward compatibility (in case someone uses another version of Plexus Archiver - the one which has different default value of umask option - with Maven Assembly Plugin and migrates to the new version of Maven Assembly Plugin with this pull request integrated). > fileMode not set in dependencySet creating format tar.gz > -------------------------------------------------------- > > Key: MASSEMBLY-791 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-791 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: permissions > Affects Versions: 2.6 > Environment: Linux and Windows > Reporter: Rick Poleshuck > Priority: Major > > The fileMode is ignored within a dependencySet while creating a tar.gz > archive. This works just fine in 2.4. > <dependencySets> > <dependencySet> > <includes> > <include>com.company:dependency-artifact</include> > </includes> > <unpack>true</unpack> > <unpackOptions> > <includes> > <include>*.py</include> > </includes> > </unpackOptions> > <outputDirectory/> > <fileMode>0750</fileMode> > <directoryMode>0750</directoryMode> > </dependencySet> > </dependencySets> > </ -- This message was sent by Atlassian Jira (v8.20.10#820010)