elharo commented on code in PR #1099:
URL: https://github.com/apache/maven/pull/1099#discussion_r1235040466
##########
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##########
@@ -353,15 +359,15 @@ public int getType() {
@Override
public boolean isNull() {
- return
(comparableQualifier(value).compareTo(RELEASE_VERSION_INDEX) == 0);
+ return value == null || value.isEmpty();
}
/**
* Returns a comparable value for a qualifier.
- *
+ * <p>
* This method takes into account the ordering of known qualifiers
then unknown qualifiers with lexical
* ordering.
- *
+ * <p>
* just returning an Integer with the index here is faster, but
requires a lot of if/then/else to check for -1
Review Comment:
From here to the end is implementation detail. It's a good comment but it
isn't needed in API doc. Move this part to a regular comment.
##########
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##########
@@ -422,6 +439,106 @@ public String toString() {
}
}
+ /**
+ * Represents a combination in the version item list.
+ * It is usually a combination of a string and a number, with the string
first and the number second
Review Comment:
nit: period at end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
