gnodet commented on code in PR #1193:
URL: https://github.com/apache/maven/pull/1193#discussion_r1251983850
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -19,10 +19,10 @@
package org.apache.maven.artifact.handler;
/**
- * An artifact handler defines for a dependency type, defined as Plexus
role:<ul>
- * <li>extension and classifier, to be able to download the file,</li>
+ * An artifact handler contains metadata derived from the dependency element
that references the artifact:<ul>
+ * <li>extension and classifier, to be able to download the file</li>
* <li>information on how to use the artifact: whether to add it to the
classpath, or to take into account its
- * dependencies.</li>
+ * dependencies</li>
Review Comment:
Should we keep the `.` and add `,` at the end of the previous `<li>`.
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -19,10 +19,10 @@
package org.apache.maven.artifact.handler;
/**
- * An artifact handler defines for a dependency type, defined as Plexus
role:<ul>
- * <li>extension and classifier, to be able to download the file,</li>
+ * An artifact handler contains metadata derived from the dependency element
that references the artifact:<ul>
Review Comment:
I don't think that's true.
The metadata is not `derived from the dependency element`. The set of
artifact handlers is reduced and provides metadata related to the `dependency
type`.
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -32,7 +32,8 @@ public interface ArtifactHandler {
String ROLE = ArtifactHandler.class.getName();
/**
- * Get the file extension associated to the file represented by the
dependency type.
+ * Returns the file name extension of the artifact;
Review Comment:
`the file name extension` -> `the default file name extension`
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -41,7 +42,7 @@ public interface ArtifactHandler {
String getDirectory();
/**
- * Get the classifier associated to the dependency type.
+ * Returns the classifier of the dependency.
Review Comment:
Agreed, `classifier` -> `default classifier`
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -19,10 +19,10 @@
package org.apache.maven.artifact.handler;
/**
- * An artifact handler defines for a dependency type, defined as Plexus
role:<ul>
- * <li>extension and classifier, to be able to download the file,</li>
+ * An artifact handler contains metadata derived from the dependency element
that references the artifact:<ul>
+ * <li>extension and classifier, to be able to download the file</li>
Review Comment:
`extension and classifier` -> `défaut extension and classifier`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
