gnodet commented on code in PR #1193: URL: https://github.com/apache/maven/pull/1193#discussion_r1252673778
########## maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java: ########## @@ -41,7 +42,7 @@ public interface ArtifactHandler { String getDirectory(); /** - * Get the classifier associated to the dependency type. + * Returns the classifier of the dependency. Review Comment: Note that the v4 api provides [`Type`](https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/Type.java) as an equivalent to v3 `ArtifactHandler`, directly accessible using [`Dependency#getType()`](https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/Dependency.java#L25-L31). Maybe the api could be improved at the same time (replace _artifact type_ with _dependency type_ as a first step for example). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org