gnodet commented on code in PR #1193:
URL: https://github.com/apache/maven/pull/1193#discussion_r1250963714
##########
maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java:
##########
@@ -41,7 +42,7 @@ public interface ArtifactHandler {
String getDirectory();
/**
- * Get the classifier associated to the dependency type.
+ * Returns the classifier of the dependency.
Review Comment:
#2 is not used with `ArtifactHandler` afaik. The `ArtifactHandler` is used
to compute #3 in case it is not explicitly set in the pom.
I think the concept of `type` leaks throughout the API. It was present in
the [v3
api](https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/Artifact.java#L76)
and in the
[model](https://github.com/apache/maven/blob/master/api/maven-api-model/src/main/mdo/maven.mdo#L1178).
However, this api is somewhat flawed because the `Artifact` is used as both
an artifact and a dependency. The v4 api tries to clear things a bit by
[splitting `Artifact`, `ArtifactCoordinate`, `Dependency` and
`DependencyCoordinate`](https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
