[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763470#comment-17763470
]
ASF GitHub Bot commented on MNG-7875:
-------------------------------------
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320853920
##########
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##########
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+ String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
If we want to cut logging (and I do agree with @elharo we log way too much),
I'd just remove this method (make it no op).
Or just leave it for PUT (leave it as before), and do not log nothing for
the rest.
Reason is simple: if you have 5 reposes, you will have 5 "Downloading...."
but only one "Downloaded", and the latter matter.s
> colorize transfer messages
> --------------------------
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
> Affects Versions: 3.9.4
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
