[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763476#comment-17763476
]
ASF GitHub Bot commented on MNG-7875:
-------------------------------------
hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320856876
##########
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##########
@@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
- message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
- message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
- message.append(" (").append(format.format(contentLength));
+ message.append(action).append(darkOn).append('
').append(direction).append(' ');
+ message.append(darkOff).append(resource.getRepositoryId());
+ message.append(darkOn).append(": ");
+ message.append(resource.getRepositoryUrl()).append(darkOff);
+ appendResource(message, resource.getResourceName());
+ message.append(darkOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
- message.append(')');
+ message.append(')').append(darkOff);
out.println(message.toString());
}
+
+ private void appendResource(StringBuilder message, String resource) {
+ if (!MessageUtils.isColorEnabled() ||
resource.endsWith("/maven-metadata.xml")) {
+ message.append(resource);
+ return;
+ }
+ // use Maven2 layout for non-metadata files:
https://maven.apache.org/repositories/layout.html
Review Comment:
please don't do what? use Maven 2 repository layout as a fact?
> colorize transfer messages
> --------------------------
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
> Affects Versions: 3.9.4
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
